Re: [PATCH v3] Support ent:relative_path

From: Martin Waitz <tali@admingilde.org>
Date: May 5, 2007, 19:32 UTC
Message-ID: <20070505193214.GD30511@admingilde.org>
In-Reply-To: <20070505033039.GD16538@spearce.org>

On Fri, May 04, 2007 at 11:30:39PM -0400, Shawn O. Pearce wrote:

Show 19 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Fri, 4 May 2007, Dana How wrote:
> > 
> > > Most commands accept relative paths,  but this is
> > > not true of arguments in ent:path format.  This
> > > patch makes all of the following git-show commands
> > > work in the git source tree (not just the first):
> > >  % cd xdiff
> > >  % git-show v1.5.2-rc0:xdiff/xemit.h
> > >  % git-show v1.5.2-rc0:./xemit.h
> > >  % git-show v1.5.2-rc0:../sha1_name.c
> > 
> > ACK.
> 
> Double ACK.  I'm in complete agreement with every point Dscho has
> made in this thread, even if I haven't quoted it.  ;-)
> 
> I *really* do not want to see "<tree-ish>:<path>" to mean include
> the current prefix, *especially* when a bare repository is involved.

we could also introduce "<tree-ish>/<path>" for absolute path entries. This would make a lot of sense for submodules:

	git show "<tree-ish>/path/to/submodule/path/inside/submodule

with only : it would not look that nice ;-) OK, we could simply say that submodules are special and that you don't have to use : to separate a commit (the submodule entry) from the path inside.

aside from that I would also really like to have both absolute and relative ways to name objects.

-- 
Martin Waitz