Re: [PATCH] git-revert: Revert revert message to old behaviour

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 23, 2007, 16:27 UTC
Message-ID: <Pine.LNX.4.64.0703230926380.6730@woody.linux-foundation.org>
In-Reply-To: <Pine.LNX.4.63.0703231705150.4045@wbgn013.biozentrum.uni-wuerzburg.de>

On Fri, 23 Mar 2007, Johannes Schindelin wrote:

Show 6 quoted lines

> 
> When converting from the shell script, based on a misreading of the
> sed invocation, the builtin included the abbreviated commit name,
> and did _not_ include the quotes around the oneline message.
> 
> This fixes it.

How about the empty line in between the message and the "This reverts commit "..

> +		add_to_msg("Revert \"");
>  		add_to_msg(oneline);
> -		add_to_msg("\nThis reverts commit ");
> +		add_to_msg("\"\nThis reverts commit ");

This should probably be

	add_to_msg("\"\n\nThis reverts commit ");

with *two* \n's, no?

		Linus