git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-revert: Revert revert message to old behaviour

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 23, 2007, 16:06 UTC
Message-ID
<Pine.LNX.4.63.0703231705150.4045@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<Pine.LNX.4.64.0703230805450.6730@woody.linux-foundation.org>

When converting from the shell script, based on a misreading of the sed invocation, the builtin included the abbreviated commit name, and did _not_ include the quotes around the oneline message.

This fixes it.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
	On Fri, 23 Mar 2007, Linus Torvalds wrote:
	
	> 
	> Can we please revert the "revert" changes to the default message?
	> 
	> Dscho?
	Yeah?
 builtin-revert.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/builtin-revert.c b/builtin-revert.c
index f3f3f5c..f4e1e22 100644
--- a/builtin-revert.c
+++ b/builtin-revert.c
@@ -296,11 +296,9 @@ static int revert_or_cherry_pick(int argc, const char **argv)
 	if (action == REVERT) {
 		base = commit;
 		next = commit->parents->item;
-		add_to_msg("Revert ");
-		add_to_msg(find_unique_abbrev(commit->object.sha1,
-					DEFAULT_ABBREV));
+		add_to_msg("Revert \"");
 		add_to_msg(oneline);
-		add_to_msg("\nThis reverts commit ");
+		add_to_msg("\"\nThis reverts commit ");
 		add_to_msg(sha1_to_hex(commit->object.sha1));
 		add_to_msg(".\n");
 	} else {
-- 
1.5.1.rc1.2356.g2054
Previous: Linus TorvaldsNext: Linus Torvalds
Message 2 of 6 in “"git revert" message changes...”
  1. Linus TorvaldsMar 23, 2007
  2. git-revert: Revert revert message to old behaviourJohannes Schindelin, Mar 23, 2007
  3. Linus TorvaldsMar 23, 2007
  4. Johannes SchindelinMar 23, 2007
  5. Junio C HamanoMar 24, 2007
  6. Johannes SchindelinMar 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.