Re: [PATCH] git-revert: Revert revert message to old behaviour

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 24, 2007, 12:34 UTC
Message-ID: <Pine.LNX.4.63.0703241333580.4045@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7v648rm0g5.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 24 Mar 2007, Junio C Hamano wrote:

Show 22 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> How about the empty line in between the message and the "This reverts 
> >> commit "..
> >> 
> >> > +		add_to_msg("Revert \"");
> >> >  		add_to_msg(oneline);
> >> > -		add_to_msg("\nThis reverts commit ");
> >> > +		add_to_msg("\"\nThis reverts commit ");
> >> 
> >> This should probably be
> >> 
> >> 	add_to_msg("\"\n\nThis reverts commit ");
> >> 
> >> with *two* \n's, no?
> >
> > Yes. Sorry.
> 
> Not only that.  
> 
> The older one had two, duplicated abbrev, and your fix reduces
> it to once, but we do not want any abbrev there.

D'oh.

Thanks, Dscho