git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-revert: Revert revert message to old behaviour

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 23, 2007, 19:13 UTC
Message-ID
<Pine.LNX.4.63.0703232013330.4045@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<Pine.LNX.4.64.0703230926380.6730@woody.linux-foundation.org>
Hi,
On Fri, 23 Mar 2007, Linus Torvalds wrote:
Show 21 quoted lines
> On Fri, 23 Mar 2007, Johannes Schindelin wrote:
> > 
> > When converting from the shell script, based on a misreading of the
> > sed invocation, the builtin included the abbreviated commit name,
> > and did _not_ include the quotes around the oneline message.
> > 
> > This fixes it.
> 
> How about the empty line in between the message and the "This reverts 
> commit "..
> 
> > +		add_to_msg("Revert \"");
> >  		add_to_msg(oneline);
> > -		add_to_msg("\nThis reverts commit ");
> > +		add_to_msg("\"\nThis reverts commit ");
> 
> This should probably be
> 
> 	add_to_msg("\"\n\nThis reverts commit ");
> 
> with *two* \n's, no?
Yes. Sorry.

Ciao, Dscho

Previous: Linus TorvaldsNext: Junio C Hamano
Message 4 of 6 in “"git revert" message changes...”
  1. Linus TorvaldsMar 23, 2007
  2. git-revert: Revert revert message to old behaviourJohannes Schindelin, Mar 23, 2007
  3. Linus TorvaldsMar 23, 2007
  4. Johannes SchindelinMar 23, 2007
  5. Junio C HamanoMar 24, 2007
  6. Johannes SchindelinMar 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.