Re: [PATCH] git-revert: Revert revert message to old behaviour
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 23, 2007, 19:13 UTC
- Message-ID
- <Pine.LNX.4.63.0703232013330.4045@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <Pine.LNX.4.64.0703230926380.6730@woody.linux-foundation.org>
Hi,
On Fri, 23 Mar 2007, Linus Torvalds wrote:
Show 21 quoted lines
> On Fri, 23 Mar 2007, Johannes Schindelin wrote:
> >
> > When converting from the shell script, based on a misreading of the
> > sed invocation, the builtin included the abbreviated commit name,
> > and did _not_ include the quotes around the oneline message.
> >
> > This fixes it.
>
> How about the empty line in between the message and the "This reverts
> commit "..
>
> > + add_to_msg("Revert \"");
> > add_to_msg(oneline);
> > - add_to_msg("\nThis reverts commit ");
> > + add_to_msg("\"\nThis reverts commit ");
>
> This should probably be
>
> add_to_msg("\"\n\nThis reverts commit ");
>
> with *two* \n's, no?Yes. Sorry.
Ciao, Dscho