git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Mar 2, 2007, 20:48 UTC
Message-ID
<Pine.LNX.4.64.0703021246480.3953@woody.linux-foundation.org>
In-Reply-To
<200703021929.20969.andyparkins@gmail.com>
On Fri, 2 Mar 2007, Andy Parkins wrote:
>  			# Commit with a parent
> -			for rev in $(git-rev-parse --not --all | git-rev-list --stdin $newrev ^$baserev)
> +			for rev in $(git-rev-list $newrev ^$baserev --not --all)

Looks fine, and I don't think it's worth changing, but you can avoid the extra caret by just moving "$baserev" to after the "--not", ie writing the thing as

	git-rev-list $newrev --not $baserev --all
instead if you want to.
> -			git-rev-parse --not --all |
> -			git-rev-list --stdin --pretty $newrev ^$baserev
> +			git log $newrev ^$baserev --not --all
And that's true here too.
		Linus
Previous: Andy ParkinsNext: Junio C Hamano
Message 5 of 9 in “Fix typo on variable name $newref should be $newrev in sample update hook”
  1. Fix typo on variable name $newref should be $newrev in sample update hookAndy Parkins, Mar 2, 2007
  2. Linus TorvaldsMar 2, 2007
  3. Andy ParkinsMar 2, 2007
  4. Remove use of git-rev-parse and replace git-rev-list --pretty with git-logAndy Parkins, Mar 2, 2007
  5. Linus TorvaldsMar 2, 2007
  6. Junio C HamanoMar 2, 2007
  7. Andy ParkinsMar 3, 2007
  8. Junio C HamanoMar 3, 2007
  9. Linus TorvaldsMar 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.