git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix typo on variable name $newref should be $newrev in sample update hook

From
APAndy Parkins <andyparkins@gmail.com>
Date
Mar 2, 2007, 10:27 UTC
Message-ID
<200703021027.00203.andyparkins@gmail.com>

The log message would be empty for new branches because git-rev-list was being passed $newref instead of the correct variable $newrev.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 templates/hooks--update |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/templates/hooks--update b/templates/hooks--update
index fd1f73d..2a707e5 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -148,7 +148,7 @@ case "$refname_type" in
 			# This shows all log entries that are not already covered by
 			# another ref - i.e. commits that are now accessible from this
 			# ref that were previously not accessible
-			git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
+			git-rev-parse --not --all | git-rev-list --stdin --pretty $newrev
 			echo $LOGEND
 		else
 			# oldrev is valid
-- 
1.5.0.2.205.g74e20
Next: Linus Torvalds
Message 1 of 9 in “Fix typo on variable name $newref should be $newrev in sample update hook”
  1. Fix typo on variable name $newref should be $newrev in sample update hookAndy Parkins, Mar 2, 2007
  2. Linus TorvaldsMar 2, 2007
  3. Andy ParkinsMar 2, 2007
  4. Remove use of git-rev-parse and replace git-rev-list --pretty with git-logAndy Parkins, Mar 2, 2007
  5. Linus TorvaldsMar 2, 2007
  6. Junio C HamanoMar 2, 2007
  7. Andy ParkinsMar 3, 2007
  8. Junio C HamanoMar 3, 2007
  9. Linus TorvaldsMar 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.