Re: [PATCH] Fix typo on variable name $newref should be $newrev in sample update hook

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 2, 2007, 16:44 UTC
Message-ID: <Pine.LNX.4.64.0703020839350.3953@woody.linux-foundation.org>
In-Reply-To: <200703021027.00203.andyparkins@gmail.com>

On Fri, 2 Mar 2007, Andy Parkins wrote:

>  			# ref that were previously not accessible
> -			git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
> +			git-rev-parse --not --all | git-rev-list --stdin --pretty $newrev

Well, it should just avoid git-rev-parse these days and do

	git rev-list --pretty $newrev --not --all

instead. And quite frankly, rather than "git rev-list --pretty", there's no real reason not to do

	git log $newrev --not --all

unless there is some subtle issue with pagers (but none of this goes to a terminal?) in which case you'd have to disable that (and then rev-list is probably simpler and more readable than adding a "GIT_PAGER=" to the front).

		Linus