Re: [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log

From: Junio C Hamano <junkio@cox.net>
Date: Mar 2, 2007, 23:10 UTC
Message-ID: <7vbqjbdyxc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200703021929.20969.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 16 quoted lines

> Linus noticed:
>
> --- >8 ---
> it should just avoid git-rev-parse these days and do
>
>   git rev-list --pretty $newrev --not --all
>
> instead. And quite frankly, rather than "git rev-list --pretty", there's
> no real reason not to do
>
>   git log $newrev --not --all
> --- 8< ---
>
> This patch makes those changes.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

Please look at your Subject: line above and ponder how it would look in the next issue of "What's cooking in git.git". Do I have to spend extra brain cycles to go back to "git log --stat" and realize that this one only updates a sample hook script?

Also, please don't do "--- >8 ---". If you want to, please use two dashes; this is purely for technical reasons.

I'll massage the log message and move "^$base --not" around as Linus suggested, but next time please be a bit more careful.