Re: [RFC] Submodules in GIT

From: Linus Torvalds <torvalds@osdl.org>
Date: Nov 28, 2006, 21:53 UTC
Message-ID: <Pine.LNX.4.64.0611281349540.4244@woody.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0611281614450.20138@iabervon.org>

On Tue, 28 Nov 2006, Daniel Barkalow wrote:

> 
> I don't think you'd ever want the same commit message for commits in two 
> projects.

I don't know about "ever", but yes, I do think submodule commits are generally totally separate things from supermodule commits.

> In any case where you'd commit a submodule in the process of 
> committing a supermodule, git would do this by recursively calling 
> git-commit, which would prompt for separate commit messages.

That certainly works, although I'm not convinved that it's necessarily a hugely important detail.

I suspect there may well be more important things UI-wise wrt submodules than the "you may have to commit submodules separately" question.

For example, doing a "git pull" is a lot more interesting, since that actually has the potential of having to resolve conflicts in submodules before the supermodule can be committed. Getting all the "git reset" behaviour right for when you decide "oops, that was too complicated" is probably a lot more important than whether you have to have a separate "commit subproject" phase for the simple cases of doing a bog-standard "git commit -a".