Re: Re : 2 questions on git-send-email usage

On Wed, 12 Jul 2006, Franck Bui-Huu wrote:

Yes. However, I think the sign-off detection is a bit broken (quite independently of your patch).

A number of people end up capitalizing the sign-off differently, so you have lines like "Signed-Off-By: Xy Zzy <xyzzy@example.org>".

Also, at least for the kernel, we often have alternative formats, like

	Acked-by: Elliot Xavier Ample <example@dummy.org>

and for that case, adding the extra newline is actually bad.

So I would suggest a totally different approach: instead of using "strstr(comments, signed_off_by)", it would probably be much better to just look for the last non-empty line, and see if it matches the format

	"^[nonspace]*: .*@.*$"

(yeah, that's not a valid regexp, but you get the idea).

On a slightly related note, I absolutely _hate_ how cherry-picking adds "(cherry-picked from commit <sha1>)" at the end. It's wrong for so many reasons, one of them being that it then breaks things like this, but the main one being that <sha1> will quite often actually end up not even _existing_ in the resulting archive (you cherry-picked from your private branch, and even if you keep your branch, you don't necessarily push it out).

Junio, can we make the default _not_ to do it, please?

			Linus