Re: Re : 2 questions on git-send-email usage

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 12, 2006, 16:37 UTC
Message-ID: <Pine.LNX.4.64.0607120931150.5623@g5.osdl.org>
In-Reply-To: <7v1wsqzt8f.fsf@assigned-by-dhcp.cox.net>

On Wed, 12 Jul 2006, Junio C Hamano wrote:

Show 8 quoted lines

> Linus Torvalds <torvalds@osdl.org> writes:
> >
> > A number of people end up capitalizing the sign-off differently, so you 
> > have lines like "Signed-Off-By: Xy Zzy <xyzzy@example.org>".
> 
> Documentation/SubmittingPatches (the kernel one) does not show
> the ugly Camel-Case-With-Hyphen spelling, and I've been wondring
> why people do that.

Yeah, I actually try to edit it to the "proper" format when I notice it (which is not most of the time, but it's pretty rare to begin with).

More commonly, people mistype their own email addresses, and _occasionally_ just mis-type the whole Signed-off-by: line (we've got a few semi-colons instead of colons in the kernel, for example, and some lines that are missing the final '>' in the email etc.

So being somewhat forgiving might help, but I think another thing that migth help is a flag to "git-am" to _not_ apply a patch that lacks a previous sign-off.

I, for example, don't use the --signoff flag, partly because I want to make sure that I sign of only on patches that already have a sign-off from the previous person when it comes as email (or I add the sign-off only after looking at the patch closely). But if there was a "--error-on-no-signoff" flag, I could use it.

			Linus