Re: Re : 2 questions on git-send-email usage

From: Junio C Hamano <junkio@cox.net>
Date: Jul 12, 2006, 16:24 UTC
Message-ID: <7v1wsqzt8f.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0607120834200.5623@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 17 quoted lines

> Yes. However, I think the sign-off detection is a bit broken (quite 
> independently of your patch).
>
> A number of people end up capitalizing the sign-off differently, so you 
> have lines like "Signed-Off-By: Xy Zzy <xyzzy@example.org>".
>
> Also, at least for the kernel, we often have alternative formats, like
>
> 	Acked-by: Elliot Xavier Ample <example@dummy.org>
>
> and for that case, adding the extra newline is actually bad.
>
> So I would suggest a totally different approach: instead of using 
> "strstr(comments, signed_off_by)", it would probably be much better to 
> just look for the last non-empty line, and see if it matches the format
>
> 	"^[nonspace]*: .*@.*$"

Documentation/SubmittingPatches (the kernel one) does not show the ugly Camel-Case-With-Hyphen spelling, and I've been wondring why people do that. A hidden agenda by me was to migrate people away from that practice, but that is an independent issue ;-).

I like your "detect lines that looks like a RFC2822 header that has some e-mail address" approach quite a lot.