From: Linus Torvalds Date: Wed, 12 Jul 2006 15:43:02 GMT Subject: Re: Re : 2 questions on git-send-email usage Message-ID: In-Reply-To: <44B4A6CA.3020206@innova-card.com> On Wed, 12 Jul 2006, Franck Bui-Huu wrote: > > [PATCH] Add a newline before appending "Signed-off-by:" > > It looks nicer. Yes. However, I think the sign-off detection is a bit broken (quite independently of your patch). A number of people end up capitalizing the sign-off differently, so you have lines like "Signed-Off-By: Xy Zzy ". Also, at least for the kernel, we often have alternative formats, like Acked-by: Elliot Xavier Ample and for that case, adding the extra newline is actually bad. So I would suggest a totally different approach: instead of using "strstr(comments, signed_off_by)", it would probably be much better to just look for the last non-empty line, and see if it matches the format "^[nonspace]*: .*@.*$" (yeah, that's not a valid regexp, but you get the idea). On a slightly related note, I absolutely _hate_ how cherry-picking adds "(cherry-picked from commit )" at the end. It's wrong for so many reasons, one of them being that it then breaks things like this, but the main one being that will quite often actually end up not even _existing_ in the resulting archive (you cherry-picked from your private branch, and even if you keep your branch, you don't necessarily push it out). Junio, can we make the default _not_ to do it, please? Linus