git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-applymbox broken?

From
Linus Torvalds <torvalds@osdl.org>
Date
Jun 12, 2006, 00:37 UTC
Message-ID
<Pine.LNX.4.64.0606111735440.5498@g5.osdl.org>
In-Reply-To
<m1wtbn468o.fsf@ebiederm.dsl.xmission.com>
On Sun, 11 Jun 2006, Eric W. Biederman wrote:
Show 5 quoted lines
> 
> This doesn't look like the From: header was in the middle of the
> message until it was imported into git so it is probably a small
> logic error that is easily corrected.  But I need to see what
> we are parsing so I can understand what is happening.

No, it's at the top of the body, although there might have been an empty line or two (ie whitespace only) before it.

> Even if the header lines are in the middle of the body?
What do you mean by "middle"?

No, it should only look at From: and Subject: lines if they are at the very top, with no other non-whitespace lines above them. But when it looks at them and uses the data from them, it should then remove them from the body - they are "conceptually" just extended header lines that just happened to technically (from an rfc822 standpoint) be in the body of the email.

		Linus
Previous: Eric W. BiedermanNext: Eric W. Biederman
Message 3 of 13 in “git-applymbox broken?”
  1. Linus TorvaldsJun 11, 2006
  2. Eric W. BiedermanJun 11, 2006
  3. Linus TorvaldsJun 12, 2006
  4. Eric W. BiedermanJun 12, 2006
  5. Ignore blank lines among this inbody headers.Eric W. Biederman, Jun 12, 2006
  6. Ignore blank lines among this inbody headersEric W. Biederman, Jun 12, 2006
  7. Eric W. BiedermanJun 12, 2006
  8. Linus TorvaldsJun 12, 2006
  9. Don't parse any headers in the real body of an email message.Eric W. Biederman, Jun 12, 2006
  10. Eric W. BiedermanJun 12, 2006
  11. Johannes SchindelinJun 12, 2006
  12. Randy.DunlapJun 12, 2006
  13. Ryan AndersonJun 13, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.