Re: git-applymbox broken?
- From
Eric W. Biederman <ebiederm@xmission.com>
- Date
- Jun 12, 2006, 18:58 UTC
- Message-ID
- <m13bea6w13.fsf@ebiederm.dsl.xmission.com>
- In-Reply-To
- <Pine.LNX.4.64.0606111735440.5498@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 8 quoted lines
> What do you mean by "middle"? > > No, it should only look at From: and Subject: lines if they are at the > very top, with no other non-whitespace lines above them. But when it looks > at them and uses the data from them, it should then remove them from the > body - they are "conceptually" just extended header lines that just > happened to technically (from an rfc822 standpoint) be in the body of the > email.
Below is an example of the kind of patch that inspired me to relax the rules on parsing in body headers (this comes from Andi Kleen quilt tree).
The first line in this instance is obviously a subject line but there is not really good way to detect that. Then we get a From: line.
Now I doubt any patches ever hit the mail in this format and it probably isn't worth it to track down every variation of patch headers in existence. But if we don't find a From: header in the body prefix it seems to make sense to keep looking for headers in the body, and to use the information if we find it.
--- Kdump i386 nmi event notification fix
From: Vivek Goyal <vgoyal@in.ibm.com>
After a crash we should wait for NMI IPI event and not for external NMI or NMI watchdog tick.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andi Kleen <ak@suse.de> Cc: Don Zickus <dzickus@redhat.com> Cc: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> ---
arch/i386/kernel/crash.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Index: linux/arch/i386/kernel/crash.c =================================================================== --- linux.orig/arch/i386/kernel/crash.c +++ linux/arch/i386/kernel/crash.c @@ -102,7 +102,7 @@ static int crash_nmi_callback(struct not struct pt_regs fixed_regs; int cpu; - if (val != DIE_NMI) + if (val != DIE_NMI_IPI) return NOTIFY_OK; regs = ((struct die_args *)data)->regs; @@ -113,7 +113,7 @@ static int crash_nmi_callback(struct not * an NMI if system was initially booted with nmi_watchdog parameter. */ if (cpu == crashing_cpu) - return 1; + return NOTIFY_STOP; local_irq_disable(); if (!user_mode_vm(regs)) {