From: Linus Torvalds Date: Mon, 12 Jun 2006 00:37:47 GMT Subject: Re: git-applymbox broken? Message-ID: In-Reply-To: On Sun, 11 Jun 2006, Eric W. Biederman wrote: > > This doesn't look like the From: header was in the middle of the > message until it was imported into git so it is probably a small > logic error that is easily corrected. But I need to see what > we are parsing so I can understand what is happening. No, it's at the top of the body, although there might have been an empty line or two (ie whitespace only) before it. > Even if the header lines are in the middle of the body? What do you mean by "middle"? No, it should only look at From: and Subject: lines if they are at the very top, with no other non-whitespace lines above them. But when it looks at them and uses the data from them, it should then remove them from the body - they are "conceptually" just extended header lines that just happened to technically (from an rfc822 standpoint) be in the body of the email. Linus