git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-applymbox broken?

From
RARyan Anderson <ryan@michonline.com>
Date
Jun 13, 2006, 03:41 UTC
Message-ID
<20060613034153.GU32457@h4x0r5.com>
In-Reply-To
<m1wtbn468o.fsf@ebiederm.dsl.xmission.com>
On Sun, Jun 11, 2006 at 05:33:59PM -0600, Eric W. Biederman wrote:
Show 24 quoted lines
> Linus Torvalds <torvalds@osdl.org> writes:
> 
> > It looks like something has broken git-applymbox lately.
> >
> > The "From: authorname" lines are no longer removed from the message, and 
> > are duplicated in the commit log. This has resulted in several recent 
> > kernel commits looking like this:
> 
> Agreed.  That isn't terribly desirable.
> Do you have the original email message some place?
> 
> There is an odd case where if someone put the From: header
> in the middle of the text that we now notice and process and I
> didn't feel right about removing a line from the middle of the
> text.
> 
> I was fixing a nasty corner case that happens if there aren't any
> mail headers at all passed to git-mailinfo.  Where we could drop
> lines without processing them at all.
> 
> This doesn't look like the From: header was in the middle of the
> message until it was imported into git so it is probably a small
> logic error that is easily corrected.  But I need to see what
> we are parsing so I can understand what is happening.

I hate to say this, because I'm bad about it, too, but we should probably have a few tests for applymbox, to cover the various scenarios discussed in this thread.

-- 
Ryan Anderson
  sometimes Pug Majere
Previous: Randy.Dunlap
Message 13 of 13 in “git-applymbox broken?”
  1. Linus TorvaldsJun 11, 2006
  2. Eric W. BiedermanJun 11, 2006
  3. Linus TorvaldsJun 12, 2006
  4. Eric W. BiedermanJun 12, 2006
  5. Ignore blank lines among this inbody headers.Eric W. Biederman, Jun 12, 2006
  6. Ignore blank lines among this inbody headersEric W. Biederman, Jun 12, 2006
  7. Eric W. BiedermanJun 12, 2006
  8. Linus TorvaldsJun 12, 2006
  9. Don't parse any headers in the real body of an email message.Eric W. Biederman, Jun 12, 2006
  10. Eric W. BiedermanJun 12, 2006
  11. Johannes SchindelinJun 12, 2006
  12. Randy.DunlapJun 12, 2006
  13. Ryan AndersonJun 13, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.