Re: [PATCH 2/2] cvsimport: cleanup commit function

From: Linus Torvalds <torvalds@osdl.org>
Date: May 23, 2006, 19:36 UTC
Message-ID: <Pine.LNX.4.64.0605231232360.5623@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0605230948280.5623@g5.osdl.org>

On Tue, 23 May 2006, Linus Torvalds wrote:

Show 15 quoted lines

> 
> Hmm. Is it just me, or does the current "git cvsimport" have new problems:
> 
> 	[torvalds@merom git]$ git cvsimport -d ~/CVS gentoo-x86
> 
> causes
> 
> 	Committing initial tree 34bd3dcd4bfd79bad35ce3fb08b2e21108195db8
> 	Server has gone away while fetching BUGS-TODO 1.1, retrying...
> 	Retry failed at /home/torvalds/bin/git-cvsimport line 366, <GEN2656> line 9.
> 
> and that's it for the import.
> 
> I don't see what would have caused it in the changes, but it definitely 
> worked earlier..

Martin, that problem seems to go away when I initialize $res to 0 in _fetchfile.

I don't know perl, and maybe local variables are pre-initialized to empty.

It's entirely possible that the fact that it now seems to work for me is purely timing-related, since I also ended up using "-P cvsps-output" to avoid having a huge cvsps binary in memory at the same time.

		Linus "perl illiterate" Torvalds