git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] cvsimport: cleanup commit function

From
Junio C Hamano <junkio@cox.net>
Date
May 23, 2006, 20:25 UTC
Message-ID
<7vsln04hf0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.64.0605231232360.5623@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 7 quoted lines
>> 	Committing initial tree 34bd3dcd4bfd79bad35ce3fb08b2e21108195db8
>> 	Server has gone away while fetching BUGS-TODO 1.1, retrying...
>...
> Martin, that problem seems to go away when I initialize $res to 0 in 
> _fetchfile. 
>
> I don't know perl, and maybe local variables are pre-initialized to empty.

When a new file that is empty is created, sub _line would call sub _fetchfile with $cnt == 0, and it can return $res which is initialized to 'undef'. That explains why sub file says $self->_line() returned an undef and I think what you did is the right fix.

Previous: Linus TorvaldsNext: Martin Langhoff
Message 70 of 82 in “irc usage..”
  1. Linus TorvaldsMay 20, 2006
  2. Junio C HamanoMay 20, 2006
  3. Jakub NarebskiMay 20, 2006
  4. Yann DirsonMay 20, 2006
  5. Donnie BerkholzMay 20, 2006
  6. Linus TorvaldsMay 20, 2006
  7. Donnie BerkholzMay 20, 2006
  8. Linus TorvaldsMay 21, 2006
  9. Linus TorvaldsMay 22, 2006
  10. Donnie BerkholzMay 22, 2006
  11. Linus TorvaldsMay 22, 2006
  12. Martin LanghoffMay 22, 2006
  13. Donnie BerkholzMay 22, 2006
  14. Martin LanghoffMay 22, 2006
  15. Linus TorvaldsMay 22, 2006
  16. Martin LanghoffMay 22, 2006
  17. Linus TorvaldsMay 22, 2006
  18. Jakub NarebskiMay 22, 2006
  19. Linus TorvaldsMay 22, 2006
  20. Matthias LederhoferMay 22, 2006
  21. Junio C HamanoMay 22, 2006
  22. Jakub NarebskiMay 23, 2006
  23. Martin LanghoffMay 22, 2006
  24. Donnie BerkholzMay 22, 2006
  25. Linus TorvaldsMay 22, 2006
  26. Donnie BerkholzMay 22, 2006
  27. Linus TorvaldsMay 22, 2006
  28. Donnie BerkholzMay 22, 2006
  29. Donnie BerkholzMay 29, 2006
  30. Martin LanghoffMay 29, 2006
  31. Donnie BerkholzMay 29, 2006
  32. Martin LanghoffMay 30, 2006
  33. Donnie BerkholzMay 30, 2006
  34. Martin LanghoffMay 30, 2006
  35. Linus TorvaldsMay 30, 2006
  36. Martin LanghoffMay 30, 2006
  37. Linus TorvaldsMay 30, 2006
  38. Martin LanghoffMay 31, 2006
  39. Donnie BerkholzMay 31, 2006
  40. Martin LanghoffMay 31, 2006
  41. Alec WarnerMay 31, 2006
  42. Martin LanghoffMay 31, 2006
  43. Alec WarnerJun 1, 2006
  44. Martin LanghoffJun 1, 2006
  45. Alec WarnerJun 5, 2006
  46. Martin LanghoffJun 5, 2006
  47. Alec WarnerJun 5, 2006
  48. Martin LanghoffJun 5, 2006
  49. SeanJun 5, 2006
  50. Martin LanghoffMay 22, 2006
  51. Linus TorvaldsMay 22, 2006
  52. Linus TorvaldsMay 22, 2006
  53. Matthias UrlichsMay 22, 2006
  54. Linus TorvaldsMay 22, 2006
  55. Martin LanghoffMay 22, 2006
  56. Martin LanghoffMay 22, 2006
  57. Linus TorvaldsMay 22, 2006
  58. Junio C HamanoMay 22, 2006
  59. Martin LanghoffMay 22, 2006
  60. Jeff KingMay 23, 2006
  61. Jeff KingMay 23, 2006
  62. 1/2 cvsimport: use git-update-index --index-infoJeff King, May 23, 2006
  63. 2/2 cvsimport: cleanup commit functionJeff King, May 23, 2006
  64. 1/2 cvsimport: use git-update-index --index-infoJeff King, May 23, 2006
  65. Martin LanghoffMay 23, 2006
  66. Junio C HamanoMay 23, 2006
  67. Martin LanghoffMay 23, 2006
  68. Linus TorvaldsMay 23, 2006
  69. Linus TorvaldsMay 23, 2006
  70. Junio C HamanoMay 23, 2006
  71. Martin LanghoffMay 23, 2006
  72. Jeff KingMay 23, 2006
  73. Martin LanghoffMay 23, 2006
  74. Morten WelinderMay 23, 2006
  75. Jeff KingMay 23, 2006
  76. Junio C HamanoMay 23, 2006
  77. Jeff KingMay 24, 2006
  78. Donnie BerkholzMay 22, 2006
  79. Thomas GlanzmannMay 21, 2006
  80. Donnie BerkholzMay 21, 2006
  81. Linus TorvaldsMay 22, 2006
  82. Jeff KingMay 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.