Re: [PATCH 2/2] cvsimport: cleanup commit function
- From
- Morten Welinder <mwelinder@gmail.com>
- Date
- May 23, 2006, 17:47 UTC
- Message-ID
- <118833cc0605231047o2012deefh5e77b8496da1e673@mail.gmail.com>
- In-Reply-To
- <20060523070007.GC6180@coredump.intra.peff.net>
Why run "env" and not just muck with %ENV?
M.
Show 9 quoted lines
> + my $pid = open2(my $commit_read, my $commit_write, > + 'env', > + "GIT_AUTHOR_NAME=$author_name", > + "GIT_AUTHOR_EMAIL=$author_email", > + "GIT_AUTHOR_DATE=$commit_date", > + "GIT_COMMITTER_NAME=$author_name", > + "GIT_COMMITTER_EMAIL=$author_email", > + "GIT_COMMITTER_DATE=$commit_date", > + 'git-commit-tree', $tree, @commit_args);