Re: [PATCH 2/2] cvsimport: cleanup commit function
- From
Jeff King <peff@peff.net>
- Date
- May 24, 2006, 09:52 UTC
- Message-ID
- <20060524095212.GA29510@coredump.intra.peff.net>
- In-Reply-To
- <7vpsi41f82.fsf@assigned-by-dhcp.cox.net>
On Tue, May 23, 2006 at 04:41:33PM -0700, Junio C Hamano wrote:
> Are you two talking about running git-commit-tree via env is two > fork-execs instead of just one? Does that have a measurable > difference?
Yes, that's what I was talking about. No, probably not a huge difference. I did some performance measurements of all of the recent cvsimport changes on a small-ish personal repo (I don't have the gentoo repo). The results were not significant (<= 1% improvement for each change). I would expect some of the changes (index-info, fetchfile) to have an impact on a repo with different characteristics (like the gentoo one).
-Peff