Re: RFC: New diff-delta.c implementation

From: Nicolas Pitre <nico@cam.org>
Date: Apr 22, 2006, 12:51 UTC
Message-ID: <Pine.LNX.4.64.0604220846040.2215@localhost.localdomain>
In-Reply-To: <6794F5B2-A277-4CD9-9BA8-509F86378E68@adacore.com>

On Sat, 22 Apr 2006, Geert Bosch wrote:

Show 10 quoted lines

> BTW, after applying the obvious fixes, I get the following
> message:
> potomac%./git-pack-objects --no-reuse-delta --stdout <lst
> Generating pack...
> Done counting 16984 objects.
> Deltifying 16984 objects.
> 100% (16984/16984) done
> fatal: delta size changed
> 
> Is this expected now I have a different algorithm?

It should not.

First, pack-objects tries to find the best object combinations producing the smallest delta. Then there is a second pass where the best delta are actually written out. When that message appears that means the delta size for the same object pair does not match between those two passes.

Nicolas