Re: RFC: New diff-delta.c implementation

From: Geert Bosch <bosch@adacore.com>
Date: Apr 22, 2006, 11:04 UTC
Message-ID: <A856A2C5-2BD7-4DC5-9CCC-CD53E9A2623C@adacore.com>
In-Reply-To: <Pine.LNX.4.64.0604212308080.2215@localhost.localdomain>

On Apr 21, 2006, at 23:19, Nicolas Pitre wrote:

Show 6 quoted lines

> It looks really interesting.
>
> It ignores the max_size argument but that is trivially fixed.
>
> Then it triggers some assertions in the code when running the test
> suite.

Yes, these were errors in the change to the GIT output format. They were trivially fixed. More importantly, I didn't finalize the indexing data, since the code was originally used in a stand-alone program that would terminate after the diff.

> I did reformat it a bit to be more inline with the rest of GIT's  
> coding
> style (and to help me read it).  I'll look at fixing the issues I can
> fix and post it back.

Please apply the attached patch first.

   -Geert

BTW. It's a shame that we don't reuse the index when comparing one  
source
      against multiple targets. Creating the index takes about 70% of  
the time.