Re: RFC: New diff-delta.c implementation

From: Geert Bosch <bosch@adacore.com>
Date: Apr 22, 2006, 13:39 UTC
Message-ID: <81E2B4A6-3591-418D-9448-47648AF4A687@adacore.com>
In-Reply-To: <Pine.LNX.4.64.0604220846040.2215@localhost.localdomain>

On Apr 22, 2006, at 08:51, Nicolas Pitre wrote:

Show 5 quoted lines

> First, pack-objects tries to find the best object combinations
> producing the smallest delta.  Then there is a second pass
> where the best delta are actually written out.  When that
> message appears that means the delta size for the same object
> pair does not match between those two passes.

OK, thanks for that info. There are very few comments in the code, or specs of either the file format used, or for function arguments. I'll look a the code again with this info.

What is the exact role of the max_size parameter that is passed to diff_delta? I took it to mean return 0 if the size of the delta would be bigger than max_size and max_size is nonzero.

I only set *delta_size when returning a nonzero delta.

   -Geert