Re: RFC: New diff-delta.c implementation

From: Junio C Hamano <junkio@cox.net>
Date: Apr 22, 2006, 17:57 UTC
Message-ID: <7vd5f9ijcy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <EB4042E4-D74E-4346-A9CA-50E9CB33F18C@adacore.com>

Geert Bosch <bosch@adacore.com> writes:

> That's about how I implemented it in my last patch.
> Is it correct that 0 means that there is no max_size?
> Should I set *delta_size to 0 when doing an early
> return, or leave it alone?

When failing, I think the convention is to return NULL and what you do with *delta_size does not matter, but Nico and pack-objects.c code can answer that better than I can ;-).

> Note that this really is a micro-optimization,

True. max_size is a hint, and the caller validates the size independently anyway, so ignoring is fine.