Re: Recent unresolved issues
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Apr 15, 2006, 16:59 UTC
- Message-ID
- <Pine.LNX.4.64.0604150958140.3701@g5.osdl.org>
- In-Reply-To
- <7vk69ri5cp.fsf@assigned-by-dhcp.cox.net>
On Sat, 15 Apr 2006, Junio C Hamano wrote:
Show 8 quoted lines
> > Pain > > "git log" wants default abbrev (to show Merge: lines and > "whatchanged -r" output compactly) while "git diff-tree -r" by > default wants to show full SHA1 unless asked, which means > "memset(revs, 0, sizeof(*revs))" in revision.c::init_revisions() > needs to be defeated by the caller.
I'd suggest just moving the call to "init_revisions()" out from "setup_revisions()" entirely.
So the calling sequence would be something like this:
init_revisions(&rev); .. any localized setup .. setup_revisions(&rev);
which isn't really all that painful, and allows us maximal flexibility for different defaults etc.
Linus