Re: Recent unresolved issues

From: Junio C Hamano <junkio@cox.net>
Date: Apr 15, 2006, 06:18 UTC
Message-ID: <7vu08vjra5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0604141751270.3701@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 10 quoted lines

> On Fri, 14 Apr 2006, Linus Torvalds wrote:
>> 
>> I think you're right, and I've probably broken "--full-diff" (causing the 
>> revparse to also use the empty set of paths). Gaah.
>
> In fact, it's broken path-limited revisions entirely. Duh. We should have 
> a test for that, so I would have noticed.
>
> I think we need two diffopt structures there - one for the actual diff, 
> and one for the pruning.

Although I've already decided to merge it up, there are small fallout from this. I've fixed the ones I noticed, but there probably remain some backward compatibility issues in commands that I do not usually use. We'll see.

Also I merged the commit prettyprinter change, but I was hoping we could instead pass down the commit object and commit format to places where log message needs to be output and write it out to the standard output instead of formatting in core.