Re: Recent unresolved issues

From: Junio C Hamano <junkio@cox.net>
Date: Apr 15, 2006, 05:06 UTC
Message-ID: <7vodz3l964.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0604142104140.3701@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 6 quoted lines

> Well, it's easy enough to do something like
>
> 	if (rev->diff)
> 		usage(no_diff_cmd_usage);
>
> for something like that.

You're right. I've swallowed all four patches with a fixlet on top; thanks.

> Although, the thing is, once we have a built-in "git diff", there's 
> actually little enough reason to ever use the old "git-diff-tree" vs 
> "git-diff-index" vs "git-diff-files" at all.

True, unless you are writing a Porcelain, that is.

Show 6 quoted lines

> It might actually be nice to prune some of the tons of git commands. At 
> some point, the fact that
>
> 	echo bin/git-* | wc -w
>
> returns 122 just makes you go "Hmm..".

Yes, but I thought the plan to deal with that was to set gitexecdir somewhere other than $(prefix)/bin; removing git-diff-* siblings would be unfriendly to Porcelains.