git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rpmbuild doesn't like '-' in version strings

From
Linus Torvalds <torvalds@osdl.org>
Date
Jan 14, 2006, 17:53 UTC
Message-ID
<Pine.LNX.4.64.0601140951230.13339@g5.osdl.org>
In-Reply-To
<43C91B25.9030707@research.att.com>
On Sat, 14 Jan 2006, John Ellson wrote:
> 
> What happened to this?   I don't particularly like my fix either, but
> some kind of fix is needed for the "make rpm" target to work.  Its still
> broken because of the '-' in the version string.
Do a "sed" for rpmbuild.

There's absolutely no point in trying to make git-describe use "_" instead of "-", since having a "-" in a tag-name is very common ("my-version"), and it would be a horrible mistake to munge the tag-names. So even if we changed "-g" into "_g" it wouldn't help anything, and just make things uglier.

This is an RPM versioning problem, and nothing more. So it should be handled by rpmbuild.

		Linus
Previous: John EllsonNext: Junio C Hamano
Message 7 of 11 in “rpmbuild doesn't like '-' in version strings”
  1. rpmbuild doesn't like '-' in version stringsJohn Ellson, Dec 30, 2005
  2. Junio C HamanoJan 6, 2006
  3. Andreas EricssonJan 7, 2006
  4. Johannes SchindelinJan 7, 2006
  5. Ryan AndersonJan 7, 2006
  6. John EllsonJan 14, 2006
  7. Linus TorvaldsJan 14, 2006
  8. Junio C HamanoJan 14, 2006
  9. John EllsonJan 14, 2006
  10. Junio C HamanoJan 14, 2006
  11. Junio C HamanoJan 16, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.