Re: [PATCH] rpmbuild doesn't like '-' in version strings

From: John Ellson <ellson@research.att.com>
Date: Jan 14, 2006, 20:25 UTC
Message-ID: <43C95E25.3070006@research.att.com>
In-Reply-To: <7v1wzaliv0.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 5 quoted lines

> John Ellson <ellson@research.att.com> writes:
>   
> I consider leaving the interim version unbuildable for binary packaging
> consider a feature.
>

Not a very helpful feature IMO.    Who is protected by this?

Show 9 quoted lines

> If you want to build your own version, I think you could locally
> tag that head and build, like:
>
> 	$ git tag -a "John's GIT 1.1.2+frotz patch" v1.1.2.John0114
> 	$ make rpmbuild
>
> Of course you can keep a patch with the sed -e 's/-/_/' in
> GIT-VERSION-GEN as Linus suggested in your development branch.
>

Thats basically all I'm looking for. I agree that is only necessary to fix the "make rpm" target. Further changes are not strictly necessary. I don't understand why it would only be useful to me?

Show 5 quoted lines

> I am not yet convinced being able to build a random
> unidentifiable binary package is a good thing, and "the number
> of minutes/seconds monotonicity" would not work in multiple
> branches case (i.e. still leaves the result unordered).
>

Since disparate branches are intrinsically unordered I was suggesting that the hash field would be used to ensure uniqueness only. The timestamp field is only for ordering within a branch.

So if someone builds rpms from two different branches, they might still have to force the particular selection they want with "rpm -Uvh --oldpackage ...", but I think this is the best that can be done in the absence of any intrinsic ordering.

Anyway, this is above and beyond doing something with sed to fix the '-' issue.

John

>
>
>