From: Linus Torvalds <torvalds@osdl.org>
Date: Sat, 14 Jan 2006 17:53:19 GMT
Subject: Re: [PATCH] rpmbuild doesn't like '-' in version strings
Message-ID: <Pine.LNX.4.64.0601140951230.13339@g5.osdl.org>
In-Reply-To: <43C91B25.9030707@research.att.com>



On Sat, 14 Jan 2006, John Ellson wrote:
> 
> What happened to this?   I don't particularly like my fix either, but
> some kind of fix is needed for the "make rpm" target to work.  Its still
> broken because of the '-' in the version string.

Do a "sed" for rpmbuild.

There's absolutely no point in trying to make git-describe use "_" instead 
of "-", since having a "-" in a tag-name is very common ("my-version"), 
and it would be a horrible mistake to munge the tag-names. So even if we 
changed "-g" into "_g" it wouldn't help anything, and just make things 
uglier.

This is an RPM versioning problem, and nothing more. So it should be 
handled by rpmbuild.

		Linus