Re: [PATCH] rpmbuild doesn't like '-' in version strings

From: Junio C Hamano <junkio@cox.net>
Date: Jan 14, 2006, 19:17 UTC
Message-ID: <7v1wzaliv0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <43C91B25.9030707@research.att.com>

John Ellson <ellson@research.att.com> writes:

Show 5 quoted lines

>> ...  In that
>> sense, maybe leaving the interim version unbuildable for binary
>> packaging might be considered a feature.
>
> What happened to this?

I consider leaving the interim version unbuildable for binary packaging consider a feature.

If you want to build your own version, I think you could locally tag that head and build, like:

	$ git tag -a "John's GIT 1.1.2+frotz patch" v1.1.2.John0114
	$ make rpmbuild

Of course you can keep a patch with the sed -e 's/-/_/' in GIT-VERSION-GEN as Linus suggested in your development branch. I am not yet convinced being able to build a random unidentifiable binary package is a good thing, and "the number of minutes/seconds monotonicity" would not work in multiple branches case (i.e. still leaves the result unordered).