Re: [PATCH] bundle: fix wrong check of read_header()'s return value & add tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 8, 2007, 17:12 UTC
Message-ID: <Pine.LNX.4.63.0703081811360.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <81b0412b0703080558ye4cff44l88eb88d4911222a0@mail.gmail.com>

Hi,

On Thu, 8 Mar 2007, Alex Riesen wrote:

Show 16 quoted lines

> On 3/8/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Tue, 6 Mar 2007, Junio C Hamano wrote:
> > > +     (
> > > +             while read x && test -n "$x"
> > > +             do
> > > +                     :;
> > > +             done
> > > +             cat
> > > +     ) <bundle1 >bundle.pack &&
> > 
> > I tried to avoid that, because it was mentioned that this does not work on
> > Cygwin for some reason I forgot.
> > 
> 
> Can't think of a reason why it would not. Just tried: works.
> It works even with \r\n line endings (which I don't understand).

IIRC there was a problem when a file was detected to be text, but continued to be binary. Mark?

Ciao, Dscho