Re: [PATCH] bundle: fix wrong check of read_header()'s return value & add tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 7, 2007, 05:15 UTC
Message-ID: <Pine.LNX.4.63.0703070613530.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.63.0703062256200.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Hi,

On Tue, 6 Mar 2007, Johannes Schindelin wrote:

> +test_expect_success 'bundle 1 has only 3 files ' '
> +	cd "$D" &&
> +	sed "1,4d" < bundle1 > bundle.pack &&

I fear this would suffer the same fate as t8001, namely that some sed would add a newline, which is plain wrong here. This is a workaround:

diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index ce96b4b..f895072 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -110,7 +110,7 @@ test_expect_failure 'unbundle 1' '
 
 test_expect_success 'bundle 1 has only 3 files ' '
 	cd "$D" &&
-	sed "1,4d" < bundle1 > bundle.pack &&
+	dd bs=136 skip=1 if=bundle1 of=bundle.pack &&
 	git index-pack bundle.pack &&
 	test 4 = $(git verify-pack -v bundle.pack | wc -l)
 '

Ciao,
Dscho