git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle: fix wrong check of read_header()'s return value & add tests

From
Mark Levedahl <mdl123@verizon.net>
Date
Mar 8, 2007, 20:43 UTC
Message-ID
<45F0756B.5080808@verizon.net>
In-Reply-To
<Pine.LNX.4.63.0703081811360.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin wrote:
Show 7 quoted lines
> IIRC there was a problem when a file was detected to be text, but 
> continued to be binary. Mark?
>
> Ciao,
> Dscho
>
>   
The problem occurs with constructs like

echo "some text stuff" > file echo "some binary stuff" >> file

The second write, being an append, ends up executed in a forked process where file was opened by the parent, and unfortunately auto-detected as a text file, such that the write from the child process ends up mangling any crlf in the stream. This occurs regardless of the defined mount type and other cygwin flags. It is definitely a bug, but is attributed to looseness in POSIX with noone claiming ownership to fix.

However, the above bug is not triggered in the construct mentioned by Junio.
Mark
Previous: Johannes Schindelin
Message 7 of 7 in “bundle: fix wrong check of read_header()'s return value & add tests”
  1. bundle: fix wrong check of read_header()'s return value & add testsJohannes Schindelin, Mar 6, 2007
  2. Johannes SchindelinMar 7, 2007
  3. Junio C HamanoMar 7, 2007
  4. Johannes SchindelinMar 8, 2007
  5. Alex RiesenMar 8, 2007
  6. Johannes SchindelinMar 8, 2007
  7. Mark LevedahlMar 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.