Re: [PATCH] bundle: fix wrong check of read_header()'s return value & add tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 8, 2007, 13:06 UTC
Message-ID: <Pine.LNX.4.63.0703081405310.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vslchio4f.fsf@assigned-by-dhcp.cox.net>

Hi,

On Tue, 6 Mar 2007, Junio C Hamano wrote:

Show 18 quoted lines

> Would this work?
> 
> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> index ce96b4b..ad589dd 100755
> --- a/t/t5510-fetch.sh
> +++ b/t/t5510-fetch.sh
> @@ -110,9 +110,16 @@ test_expect_failure 'unbundle 1' '
>  
>  test_expect_success 'bundle 1 has only 3 files ' '
>  	cd "$D" &&
> -	sed "1,4d" < bundle1 > bundle.pack &&
> +	(
> +		while read x && test -n "$x"
> +		do
> +			:;
> +		done
> +		cat
> +	) <bundle1 >bundle.pack &&

I tried to avoid that, because it was mentioned that this does not work on Cygwin for some reason I forgot.

Ciao, Dscho