Re: [PATCH 3/4] git-bundle: various fixups

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 6, 2007, 02:13 UTC
Message-ID: <Pine.LNX.4.63.0703060310120.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vtzwzurss.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 5 Mar 2007, Junio C Hamano wrote:

> verify_bundle() returned with an error early only when all
> prerequisite commits were missing.  It should error out much
> earlier when some are missing.

The idea was to list _all_ missing prerequisites so that git-bundle will not complain _again_, about different missing prerequisites, when the first set of missing prerequisites was obtained.

The check only prevented looking for _reachable_ commits, when none of the prerequisites were found in the object database to begin with.

Show 5 quoted lines

> When the rev-list is limited in ways other than revision range (e.g. 
> --max-count or --max-age), create_bundle() listed all positive refs 
> given from the command line as if they are available, but resulting pack 
> may not have some of them.  Add a logic to make sure all of them are 
> included, and error out otherwise.

Good catch!

Ciao, Dscho