Re: [PATCH] revision walker: Fix --boundary when limited

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 5, 2007, 19:00 UTC
Message-ID: <Pine.LNX.4.63.0703051957090.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.63.0703051951340.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Hi,

On Mon, 5 Mar 2007, Johannes Schindelin wrote:

Show 14 quoted lines

> 	On Mon, 5 Mar 2007, Junio C Hamano wrote:
> 
> 	> "Santi Béjar" <sbejar@gmail.com> writes:
> 	> 
> 	> > the --topo-order does not play well with --boundary and 
> 	> > --max-count.
> 	> >
> 	> > $ git-rev-list --boundary --max-count=50 5ced0 | wc -l
> 	> > 56
> 	> > $ git-rev-list --topo-order --boundary --max-count=50 5ced0 \
> 	> >   | wc -l
> 	> > 8846
> 	> >
> 	> > (5ced0 is git.git's master). I think it should be 56 for both.

Side note: with the patch I am replying to, the latter command returns 51. This is correct, since the only boundary commit it shows (1db8b60b) has (all) the other 5 commits as ancestors.

The behaviour of both is correct: in the former case, there is not enough information to tell that one of the 6 boundary commits reaches all the others.

Ciao, Dscho