Re: [PATCH 2/4] revision traversal: retire BOUNDARY_SHOW

From: Junio C Hamano <junkio@cox.net>
Date: Mar 6, 2007, 11:34 UTC
Message-ID: <7vd53mppvb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0703060322270.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 6 quoted lines

>> > This should help performance, as not all reachable commits are traversed 
>> > any more.
>> 
>> You prevented that with "while (i &&" part already, didn't you?
>
> Well, yes. I also wanted to prevent going down all paths, though.

If we wanted to bundle "-8 A B", I think we would make 'x' and 'y' prereqs, as they are the direct parents commits that are shown, and that themselves are not shown.

         .---*---*---*---*---* A
        /
    ---x---y---*---*---* B

If we say upon hitting prereq (x and y) we stop traversal by marking the parent UNINTERESTING, I suspected that we may not find out 'x' with get_revision() loop, and that was why I chose not to. Instead the loop stops by finding y and then x (and by saying "ok I needed to find two and now I have two".

But this probably needs more optimization.