Re: [PATCH] revision walker: Fix --boundary when limited

From: Junio C Hamano <junkio@cox.net>
Date: Mar 5, 2007, 21:10 UTC
Message-ID: <7v7itvxupl.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0703051951340.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 10 quoted lines

> In case revs->limited == 1, the revision walker really reads
> everything into revs->commits. The behaviour introduced in
> c4025103fa does not behave correctly in that case.
>
> It used to say: everything which is _still_ in the pipeline
> must be a boundary commit.
>
> So, in the case that revs->limited == 1, filter out all commits
> which are not dangling, in effect marking only the dangling
> ones as boundary commits.

That's what I suggested initially but I think that is wrong. We should show only unshown immediate parents of shown commits at that stage.