git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] print_wrapped_text: fix output for negative indent

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 2, 2007, 14:28 UTC
Message-ID
<Pine.LNX.4.63.0703021526210.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vslcoghcd.fsf@assigned-by-dhcp.cox.net>

When providing a negative indent, it means that -indent columns were already printed. Fix a bug where the function ate the first character if already the first word did not fit into the first line.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	On Fri, 2 Mar 2007, Junio C Hamano wrote:
	> Is it just me or is your word wrapper misbehaving?
	It was. It separated printing of the file name and of the comma. 
	This is fixed with my next reply, but it triggered this small
	bug.
 utf8.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/utf8.c b/utf8.c
index ea23a6e..9e1a6d4 100644
--- a/utf8.c
+++ b/utf8.c
@@ -268,7 +268,7 @@ int print_wrapped_text(const char *text, int indent, int indent2, int width)
 			}
 			else {
 				putchar('\n');
-				text = bol = space + 1;
+				text = bol = space + isspace(*space);
 				space = NULL;
 				w = indent = indent2;
 			}
-- 
1.5.0.2.780.g57e5-dirty
Previous: Junio C HamanoNext: Johannes Schindelin
Message 10 of 24 in “Add --pretty=changelog”
  1. Add --pretty=changelogJohannes Schindelin, Feb 27, 2007
  2. Nicolas PitreFeb 27, 2007
  3. Johannes SchindelinFeb 27, 2007
  4. Eric WongFeb 27, 2007
  5. Junio C HamanoFeb 27, 2007
  6. 4/3 Rename --pretty=changelog to --pretty=gnucl, and fix a bugJohannes Schindelin, Feb 28, 2007
  7. Nicolas PitreFeb 28, 2007
  8. --amend Rename --pretty=changelog to --pretty=gnuclJohannes Schindelin, Feb 28, 2007
  9. Junio C HamanoMar 2, 2007
  10. print_wrapped_text: fix output for negative indentJohannes Schindelin, Mar 2, 2007
  11. --pretty=gnucl: avoid line wrapping before the commaJohannes Schindelin, Mar 2, 2007
  12. Junio C HamanoMar 3, 2007
  13. Johannes SchindelinMar 3, 2007
  14. Junio C HamanoMar 3, 2007
  15. Simon JosefssonMar 1, 2007
  16. Johannes SchindelinMar 1, 2007
  17. Shawn O. PearceMar 1, 2007
  18. Johannes SchindelinMar 1, 2007
  19. Junio C HamanoMar 2, 2007
  20. Simon JosefssonMar 2, 2007
  21. Junio C HamanoMar 2, 2007
  22. Simon JosefssonMar 2, 2007
  23. Johannes SchindelinMar 2, 2007
  24. Simon JosefssonMar 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.