Re: [PATCH] Add --pretty=changelog

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 1, 2007, 18:15 UTC
Message-ID: <Pine.LNX.4.63.0703011912090.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <87y7mhrnrc.fsf@latte.josefsson.org>

Hi,

On Thu, 1 Mar 2007, Simon Josefsson wrote:

Show 7 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > This outputs the log in GNU ChangeLog format.
> 
> Many thanks!  I ran this in my cvs->git repository for libtasn1, and 
> then did a diff against the output from cvs2cl in the old repository. 
> Here are some categories of differences:

No good deed goes unpunished, they say...

> 1) Indentation should be under the '*'.  Compare (wrong):
> 
>         * src/asn1Coding.c, src/asn1Decoding.c, src/asn1Parser.c: Improve
>           --help output.  Assume getopt_long, since gnulib provides it.

I saw that in your mail already, and I find the style cvs2cl outputs ugly.

Show 5 quoted lines

> 2) Don't log anything for empty messages:
> 
>         * gl/.cvsignore: *** empty log message ***
> 
> Possibly, this should be an option.

It does not log anything for empty messages. Not even a colon.

Show 15 quoted lines

> 3) Possible charset problem?  Compare this (correct):
> 
>         * configure.in: Fix -Wno-pointer-sign test to respect user-defined
>         CFLAGS.  Reported by "Diego 'Flameeyes' Pettenò"
>         <flameeyes@gentoo.org>.
> 
> with (wrong):
> 
>         * configure.in: Fix -Wno-pointer-sign test to respect user-defined
>           CFLAGS.  Reported
> 
> The git log do seem to contain the correct data, though, from git-log:
> 
>     Fix -Wno-pointer-sign test to respect user-defined CFLAGS.  Reported
>     by "Diego 'Flameeyes' Pettenò" <flameeyes@gentoo.org>.

No charset problem. In Git commit messages, the first line is special. It is the so called "oneline" description. If you wrap the oneline, it's your fault, not Git's.

> 4) Weird error, compare (correct):

This is exactly the same as 3).

> I'll let you fix these and resume the diff later. :)

As far as I am concerned, I don't think there is anything to fix. Except maybe the wrapping of your commit messages, but I guess it is too late now to change them?

> Can I pull your git tree from somewhere?  Applying patches from e-mail 
> is kind of boring.

No, I don't have a public Git tree.

Ciao, Dscho