Re: [PATCH] Add --pretty=changelog
- From
Junio C Hamano <junkio@cox.net>
- Date
- Mar 2, 2007, 04:39 UTC
- Message-ID
- <7v8xegntro.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0703011912090.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 19 quoted lines
>> 3) Possible charset problem? Compare this (correct): >> >> * configure.in: Fix -Wno-pointer-sign test to respect user-defined >> CFLAGS. Reported by "Diego 'Flameeyes' Pettenò" >> <flameeyes@gentoo.org>. >> >> with (wrong): >> >> * configure.in: Fix -Wno-pointer-sign test to respect user-defined >> CFLAGS. Reported >> >> The git log do seem to contain the correct data, though, from git-log: >> >> Fix -Wno-pointer-sign test to respect user-defined CFLAGS. Reported >> by "Diego 'Flameeyes' Pettenò" <flameeyes@gentoo.org>. > > No charset problem. In Git commit messages, the first line is special. It > is the so called "oneline" description. If you wrap the oneline, it's your > fault, not Git's.
I suspect that oneline mode in pretty_print_commit() _could_ treat the first line specially, by grabbing the first paragraph and squashing LF into SP. Commit messages that follow the kernel convention (which matches well with what applymbox and am creates) would always have a single line in the first paragraph, so there is no change in behaviour, while commits that lack the empty line on the second line, most often seen in cvsimport, would get something a bit more readable than the status quo.
Not that I care too deeply about it.