Re: [PATCH] Add --pretty=changelog

From: Simon Josefsson <simon@josefsson.org>
Date: Mar 2, 2007, 10:15 UTC
Message-ID: <87abywrly0.fsf@latte.josefsson.org>
In-Reply-To: <7vejo8ezde.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 9 quoted lines

> Simon Josefsson <simon@josefsson.org> writes:
>
>> The problem here is that CVS insert '*** empty log message ***' when
>> you didn't supply a log message, and doing something intelligent with
>> such logs would be useful.
>
> If that is indeed the case then I suspect that cvs-to-git
> conversion should know about it and strip the artificial
> string.

Yes, actually, that seems like a better solution.

Btw, there is a custom to work around cvs translating empty log messages into '*** empty log message ***' strings, and that is to commit a log consisting of '.'. Translating both of those cvs log messages into a '' git log message, during cvs-import, seems like a useful change.

Show 9 quoted lines

>> But I want more than the oneline comment in the ChangeLog?  There is
>> no size limit on ChangeLog messages, and having as much information as
>> possible available is better.
>
> I think this was purely underspecification when your request was
> passed to Johannes.
>
> I've merged Johannes's gnucl series to 'next' but haven't pushed
> out, so I'll revert it.

Sorry for the trouble!

Also thanks, Johannes, for working so quickly on this. Seeing the first version of the ChangeLog output from your patched git allowed me to realize that the imported cvs history seemed ok. After replacing 'cvs2cl' and 'cvsco' I couldn't find any other more cvs-specific features in the project. I have just released the first version of libtasn1 from git instead of cvs. More projects will follow...

/Simon