Re: [PATCH] shortlog: fix segfault on empty authorname

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 10, 2006, 22:43 UTC
Message-ID: <Pine.LNX.4.63.0612102342490.28348@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20061210034524.GA11819@coredump.intra.peff.net>

Hi,

On Sat, 9 Dec 2006, Jeff King wrote:

Show 18 quoted lines

> On Sun, Dec 10, 2006 at 12:21:03AM +0100, Johannes Schindelin wrote:
> 
> > > Instead, remove at most one space between name and address.
> > 
> > Why? We can fix it properly: Instead of
> > 
> > > -				while (isspace(bob[-1]))
> > > +				if (isspace(bob[-1]))
> > 
> > do something like
> > 
> > 				while (bob - 1 != buffer + 7 && 
> > 						isspace(bob[-1]))
> 
> It doesn't look like there are ever extra spaces to get soaked up in the
> kernel or git repositories, but if there is a reason to expect
>   Full Name    <user@domain>
> then we should probably replace my fix with yours.

This is exactly the kind of assumption which led to the bug to begin with.

Ciao, Dscho