Re: [PATCH] shortlog: fix segfault on empty authorname

From: Jeff King <peff@peff.net>
Date: Dec 10, 2006, 03:45 UTC
Message-ID: <20061210034524.GA11819@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.63.0612100019270.28348@wbgn013.biozentrum.uni-wuerzburg.de>

On Sun, Dec 10, 2006 at 12:21:03AM +0100, Johannes Schindelin wrote:

Show 11 quoted lines

> > Instead, remove at most one space between name and address.
> 
> Why? We can fix it properly: Instead of
> 
> > -				while (isspace(bob[-1]))
> > +				if (isspace(bob[-1]))
> 
> do something like
> 
> 				while (bob - 1 != buffer + 7 && 
> 						isspace(bob[-1]))

It doesn't look like there are ever extra spaces to get soaked up in the
kernel or git repositories, but if there is a reason to expect
  Full Name    <user@domain>
then we should probably replace my fix with yours.