git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] shortlog: fix segfault on empty authorname

From
Junio C Hamano <junkio@cox.net>
Date
Dec 10, 2006, 06:01 UTC
Message-ID
<7vejr85lxq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20061210034524.GA11819@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> It doesn't look like there are ever extra spaces to get soaked up in the
> kernel or git repositories, but if there is a reason to expect
>   Full Name    <user@domain>
> then we should probably replace my fix with yours.

As far as I know, commit-tree removes the extra space if exists, so your fix would be fine in practice.

People could write crappy replacements of plumbing, and we may end up with names with trailing whitespaces, but with your fix at least that would not make us crash, and it may even be considered a feature -- it would serve as a coalmine canary to detect such a broken alternative program that creates bogus commit objects.

We might want to tighten fsck-objects to warn about them, though. But that is probably rather low priority.

Previous: Jeff KingNext: Johannes Schindelin
Message 6 of 8 in “builtin git-shortlog still broken”
  1. Nicolas PitreDec 9, 2006
  2. shortlog: fix segfault on empty authornameJeff King, Dec 9, 2006
  3. Nicolas PitreDec 9, 2006
  4. Johannes SchindelinDec 9, 2006
  5. Jeff KingDec 10, 2006
  6. Junio C HamanoDec 10, 2006
  7. Johannes SchindelinDec 10, 2006
  8. Johannes SchindelinDec 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.