Re: [PATCH] shortlog: fix segfault on empty authorname

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Dec 9, 2006, 23:21 UTC

Message-ID

<Pine.LNX.4.63.0612100019270.28348@wbgn013.biozentrum.uni-wuerzburg.de>

In-Reply-To

<20061209040421.GA29113@coredump.intra.peff.net>

Hi,

On Fri, 8 Dec 2006, Jeff King wrote:

> Instead, remove at most one space between name and address.

Why? We can fix it properly: Instead of

> -				while (isspace(bob[-1]))
> +				if (isspace(bob[-1]))

do something like

				while (bob - 1 != buffer + 7 && 
						isspace(bob[-1]))