Re: git /objects directory created 755 by default?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 22, 2005, 17:31 UTC
Message-ID: <Pine.LNX.4.63.0512221823460.19925@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <43AAD9D7.1070503@op5.se>

Hi,

On Thu, 22 Dec 2005, Andreas Ericsson wrote:

Show 10 quoted lines

> Johannes Schindelin wrote:
> > Hi,
> > 
> > this is getting silly. The problem is: how to setup a shared repository,
> > i.e. a repository into which different users can push their updates.
> > 
> 
> You're simplifying. Your question was
> "How can I set up a repository for multiple users to write to without setting
> a global umask for non-interactive shells?"

No, I am not. My question really was: how do I setup a shared repository?

Now, my intention was to make it as easy as possible.

Show 7 quoted lines

> Junio said:
> "I agree the setting should not be limited to git-shell, but I do
> not think setting "umask" from git configuration is the right
> way either.  For files and directories under $GIT_DIR, maybe
> imposing the policy git configuration file has is OK, but I
> think honoring the user's umask is the right thing for working
> tree files."

IMHO Junio is wrong here. If the repository is write-shared, then the working directory should be write-shared as well (or checkout should be DENIED), else you get all kinds of problems.

Show 5 quoted lines

> which I whole-heartedly agree with. I'd be completely furious if a tool
> ignored the umask I use for checking out files of a local repository just
> because I happen to do some work at the machine where the repo is stored (I
> imagine this couldn't possibly affect repositories cloned remotely, although
> that would surely have me going ballistic).

I do not understand what you mean by "repositories cloned remotely".

And if you really are working in the working directory of the shared repository, and a user (I know I would do it just to annoy you) pushes a new HEAD while you have modified files, you deserve what you get: a complete mess.

As for setting the umask only when writing into $GIT_DIR: unless somebody convinces me that it solves a problem, this is unncessary work.

You are free to ignore my warnings and my patch, I got no problem with that.

You are also free to wait for users to complain why this and that breaks, or why setting up a shared repository has to be hard, and apply my patch then.

Hth, Dscho